perf/x86/intel/uncore: Let init_box() callback report failures

Browse source

The init_box() callback currently returns void, so initialization
failures are silently ignored and the box is still marked initialized.

Change the callback to return int so platform code can report errors
back to the common uncore layer.

Update uncore_box_init() to set the initialized flag only when
init_box() succeeds.  Because box->refcnt guarantees that at most
one CPU calls uncore_box_init() for a given box at a time, plain
__set_bit() is safe for the initialized flag without atomic overhead.

Convert all init_box() implementations to return 0 on success or a
negative error code on failure.  This is a prerequisite for propagating
initialization errors to the caller so they can be handled properly.

Signed-off-by: Zide Chen <zide.chen@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Link: https://patch.msgid.link/20260611160033.66760-4-zide.chen@intel.com

...

This commit is contained in:

Zide Chen 2026-06-11 09:00:28 -07:00 • committed by Peter Zijlstra

parent 7d3a9ff988

commit cbbc25209c

6 changed files with 126 additions and 77 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

arch/x86/events/intel/uncore.h

View file

21

arch/x86/events/intel/uncore_discovery.c

View file

6

arch/x86/events/intel/uncore_discovery.h

View file

3

arch/x86/events/intel/uncore_nhmex.c

View file

80

arch/x86/events/intel/uncore_snb.c

View file

77

arch/x86/events/intel/uncore_snbep.c

View file