net: atlantic: Fix NULL dereference of skb pointer in

Browse source

If is_ptp_ring == true in the loop of __aq_ring_xdp_clean function,
then a timestamp is stored from a packet in a field of skb object,
which is not allocated at the moment of the call (skb == NULL).

Generalize aq_ptp_extract_ts and other affected functions so they don't
work with struct sk_buff*, but with struct skb_shared_hwtstamps*.

Found by Linux Verification Center (linuxtesting.org) with SVACE

Fixes: 26efaef759 ("net: atlantic: Implement xdp data plane")
Signed-off-by: Daniil Maximov <daniil31415it@gmail.com>
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Link: https://lore.kernel.org/r/20231204085810.1681386-1-daniil31415it@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

...

This commit is contained in:

Daniil Maximov 2023-12-04 11:58:10 +03:00 • committed by Paolo Abeni

parent 7037d95a04

commit cbe860be36

3 changed files with 19 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/net/ethernet/aquantia/atlantic/aq_ptp.c

View file

4

drivers/net/ethernet/aquantia/atlantic/aq_ptp.h

View file

18

drivers/net/ethernet/aquantia/atlantic/aq_ring.c

View file