Introduce "hcall" pointer to indicate pending hypercall.

Browse source

Currently we look at the "trapnum" to see if the Guest wants a
hypercall.  But once the hypercall is done we have to reset trapnum to
a bogus value, otherwise if we exit to userspace and return, we'd run
the same hypercall twice (that was a nasty bug to find!).

This has two main effects:

1) When Jes's patch changes the hypercall args to be a generic "struct
   hcall_args" we simply change the type of "lg->hcall".  It's set by
   arch code, so if it has to copy args or something it can do so, and
   point "hcall" into lg->arch somewhere.

2) Async hypercalls only get run when an actual hypercall is pending.
   This simplfies the code a little and is a more logical semantic.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

...

This commit is contained in:

Rusty Russell 2007-10-22 11:03:30 +10:00

parent 4614a3a3b6

commit cc6d4fbcef

4 changed files with 34 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/lguest/core.c

View file

48

drivers/lguest/hypercalls.c

View file

3

drivers/lguest/lg.h

View file

13

drivers/lguest/x86/core.c

View file