perf kvm: Kill STRDUP_FAIL_EXIT()

Browse source

It's used to pass command line options to a copied argv.  But there's no
reason to make the copies as it's all used in the same function.  It can
simply use stack variables.

In fact, it fixes a subtle double free issue.  As parse_options() can
move contents in argv[], some entries may point to the same item.  So
freeing all items in the argv could trigger a double free.  With stack
variables, we don't need to allocate and free them.

Tested-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

...

This commit is contained in:

Namhyung Kim 2026-07-01 12:41:50 -07:00

parent 95e6323838

commit cd589eba99

4 changed files with 24 additions and 53 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

54

tools/perf/builtin-kvm.c

View file

4

tools/perf/util/kvm-stat-arch/kvm-stat-powerpc.c

View file

9

tools/perf/util/kvm-stat-arch/kvm-stat-x86.c

View file

10

tools/perf/util/kvm-stat.h

View file