IB/ipoib: Use cancel_delayed_work_sync for neigh-clean task

Browse source

The neigh_reap_task is self restarting, but so long as we call
cancel_delayed_work_sync() it will be guaranteed to not be running and
never start again. Thus we don't need to have the racy
IPOIB_STOP_NEIGH_GC bit, or the confusing mismatch of places sometimes
calling flush_workqueue after the cancel.

This fixes a situation where the GC work could have been left running
in some rare situations.

Signed-off-by: Erez Shitrit <erezsh@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

...

This commit is contained in:

Erez Shitrit 2018-07-29 11:34:52 +03:00 • committed by Jason Gunthorpe

parent 577e07ffba

commit cda8daf179

2 changed files with 10 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/infiniband/ulp/ipoib/ipoib.h

View file

33

drivers/infiniband/ulp/ipoib/ipoib_main.c

View file