x86/apic: Ensure ICR register write value is handled as 32 bits

Browse source

The low 32-bit ICR data is prepared by __prepare_ICR(), which returns a 32-bit
value. However, when this value is assigned to a new variable, it's easy to
mistakenly declare that variable with a different width.

To avoid this class of mistakes, use __prepare_ICR() directly as the function
argument instead of storing its result in an intermediate variable. This also
shaves off a bunch of lines in the code.

There should be no functionality change resulting from this.

Signed-off-by: Melody Wang <huibo.wang@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Acked-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260708012117.177959-1-huibo.wang@amd.com

...

This commit is contained in:

Melody Wang 2026-07-08 01:21:17 +00:00 • committed by Borislav Petkov (AMD)

parent 7bdcb5b3a9

commit cdb4d57c3e

3 changed files with 3 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

arch/x86/kernel/apic/local.h

View file

4

arch/x86/kernel/apic/x2apic_phys.c

View file

5

arch/x86/kernel/apic/x2apic_savic.c

View file