mwifiex: unregister wiphy before freeing resources

Browse source

It's possible for some control interfaces (e.g., scans, set freq) to be
active after we've stopped our main work queue and the netif TX queues.
These don't get completely shut out until we've unregistered the wdevs
and wiphy.

So let's only free command buffers and poison our lists after
wiphy_unregister().

This resolves various use-after-free issues seen when resetting the
device.

Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

...

This commit is contained in:

Brian Norris 2017-07-24 18:13:21 -07:00 • committed by Kalle Valo

parent 643acea629

commit ce32d1d837

3 changed files with 10 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/net/wireless/marvell/mwifiex/init.c

View file

7

drivers/net/wireless/marvell/mwifiex/main.c

View file

1

drivers/net/wireless/marvell/mwifiex/main.h

View file