drm/amdgpu: Use memset32 for SDMA padding

Browse source

Instead of open coding it via the inefficient amdgpu_ring_write(), which
which the compiler is not able to optimise much, we can add a new
amdgpu_ring_fill() helper which pads using memset32. We do this by moving
the existing implementation from amdgpu_ring_insert_nop(), which is used
by the GFX rings, and then individually convert all the SDMA insert_nop
implementations.

For SDMA this should have a lesser benefit than for GFX (only SDMA v4.0
uses the 256 byte ring padding while the rest use 16), but it does not
harm to be consistent.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Tvrtko Ursulin 2026-09-14 15:54:26 +01:00 • committed by Alex Deucher

parent 789551e08e

commit cf48bd0a46

11 changed files with 90 additions and 88 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c

View file

26

drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c

View file

15

drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c

View file