xfs: remove xfs_btree_cur private firstblock field

Browse source

The bmbt cursor private structure has a firstblock field that is
used to maintain locking order on bmbt allocations. The field holds
an actual firstblock value (as opposed to a pointer), so it is
initialized on cursor creation, updated on allocation and then the
value is transferred back to the source before the cursor is
destroyed.

This value is always transferred from and back to the ->t_firstblock
field. Since xfs_btree_cur already carries a reference to the
transaction, we can remove this field from xfs_btree_cur and the
associated copying. The bmbt allocations will update the value in
the transaction directly.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

...

This commit is contained in:

Brian Foster 2018-07-11 22:26:29 -07:00 • committed by Darrick J. Wong

parent 280253d213

commit cf612de732

3 changed files with 7 additions and 32 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

fs/xfs/libxfs/xfs_bmap.c

View file

10

fs/xfs/libxfs/xfs_bmap_btree.c

View file

1

fs/xfs/libxfs/xfs_btree.h

View file