ASoC: STI: Fix null ptr deference in IRQ handler

Browse source

With RTlinux a race condition has been found that leads to NULL ptr crash:
- On CPU 0: uni_player_irq_handler is called to treat XRUN
 "(player->state == UNIPERIF_STATE_STOPPED)" is FALSE so status is checked,
 dev_err(player->dev, "FIFO underflow error detected") is printed
and then snd_pcm_stream_lock should be called to lock stream for stopping.
- On CPU 1: application stop and close the stream.
Issue is that the stop and shutdown functions are executed while
"FIFO underflow error detected" is printed.
So when CPU 0 calls snd_pcm_stream_lock, player->substream is already null.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Arnaud Pouliquen 2017-03-28 15:04:55 +02:00 • committed by Mark Brown

parent 3c9d3f1bc2

commit d05d862ead

3 changed files with 45 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

sound/soc/sti/uniperif.h

View file

35

sound/soc/sti/uniperif_player.c

View file

24

sound/soc/sti/uniperif_reader.c

View file