s390/qeth: defer RX modesetting

Browse source

.ndo_set_rx_mode gets called in process context, but while holding the
addr_list spinlock. Which means we currently can't sleep while
re-programming the HW, and need to poll for IO completion. That's bad,
in particular since receiving the cmd response can fail silently and
we're then polling until the timeout hits.

As a first step towards eliminating the IO completion polling, run the
RX modeset from a work element and only take the addr_list lock while
updating the RX mode address cache.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Julian Wiedmann 2019-03-28 16:39:19 +01:00 • committed by David S. Miller

parent 1571e2fdac

commit d0c7482566

3 changed files with 48 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/s390/net/qeth_core.h

View file

22

drivers/s390/net/qeth_l2_main.c

View file

42

drivers/s390/net/qeth_l3_main.c

View file