ASoC: qcom: lpass: Make asoc_qcom_lpass_cpu_platform_remove() return void

Browse source

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code.  However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

asoc_qcom_lpass_cpu_platform_remove() returned zero unconditionally.
Make it return void instead and convert all users to struct
platform_device::remove_new().

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231013221945.1489203-15-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Uwe Kleine-König 2023-10-14 00:19:52 +02:00 • committed by Mark Brown

parent 8210f496c3

commit d0cc676c42

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

6 changed files with 6 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

sound/soc/qcom/lpass-apq8016.c

View file

5

sound/soc/qcom/lpass-cpu.c

View file

2

sound/soc/qcom/lpass-ipq806x.c

View file

2

sound/soc/qcom/lpass-sc7180.c

View file

2

sound/soc/qcom/lpass-sc7280.c

View file

2

sound/soc/qcom/lpass.h

View file