xfs: factor out a helper for a single XFS_IOC_ATTRMULTI_BY_HANDLE op

Browse source

Add a new helper to handle a single attr multi ioctl operation that
can be shared between the native and compat ioctl implementation.

There is a slight change in behaviour in that we don't break out of the
loop when copying in the attribute name fails.  The previous behaviour
was rather inconsistent here as it continued for any other kind of
error, and that we don't clear the flags in the structure returned
to userspace, a behavior only introduced as a bug fix in the last
merge window.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Chandan Rajendra <chandanrlinux@gmail.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

...

This commit is contained in:

Christoph Hellwig 2020-02-26 17:30:31 -08:00 • committed by Darrick J. Wong

parent 2282a9e651

commit d0ce643911

3 changed files with 59 additions and 106 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

97

fs/xfs/xfs_ioctl.c

View file

18

fs/xfs/xfs_ioctl.h

View file

50

fs/xfs/xfs_ioctl32.c

View file