drm/vkms: Move frame_info into vkms_plane_state

Browse source

The vkms_frame_info structure is allocated separately in
vkms_plane_duplicate_state() and freed in vkms_plane_destroy_state(),
but has the exact same lifetime as the vkms_plane_state that contains
it.

This separate allocation is fragile: frame_info is only allocated in
duplicate_state, so any other path that creates a vkms_plane_state
produces a state with a NULL frame_info pointer. Both
vkms_plane_atomic_update() and vkms_plane_destroy_state() dereference
it unconditionally when a CRTC is set.

Embed frame_info directly in vkms_plane_state. The structure is
zero-initialized as part of the kzalloc, removing the need for a
separate allocation and its error handling in duplicate_state, and the
matching kfree in destroy_state.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patch.msgid.link/20260908-drm-no-more-plane-reset-v4-2-a31b3fcfc989@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>

...

This commit is contained in:

Maxime Ripard 2026-09-08 16:46:33 +02:00

parent 8c733e74ad

commit d1efdf6c84

No known key found for this signature in database

GPG key ID: 275FCE19A23DBE76

4 changed files with 44 additions and 57 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

30

drivers/gpu/drm/vkms/vkms_composer.c

View file

2

drivers/gpu/drm/vkms/vkms_drv.h

View file

48

drivers/gpu/drm/vkms/vkms_formats.c

View file

21

drivers/gpu/drm/vkms/vkms_plane.c

View file