xfs: fix dentry aliasing issues in open_by_handle

Browse source

Open by handle just grabs an inode by handle and then creates itself
a dentry for it.  While this works for regular files it is horribly
broken for directories, where the VFS locking relies on the fact that
there is only just one single dentry for a given inode, and that
these are always connected to the root of the filesystem so that
it's locking algorithms work (see Documentations/filesystems/Locking)

Remove all the existing open by handle code and replace it with a small
wrapper around the exportfs code which deals with all these issues.
At the same time we also make the checks for a valid handle strict
enough to reject all not perfectly well formed handles - given that
we never hand out others that's okay and simplifies the code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>

...

This commit is contained in:

Christoph Hellwig 2009-01-19 02:02:57 +01:00 • committed by Christoph Hellwig

parent 9d87c3192d

commit d296d30a99

4 changed files with 196 additions and 300 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

fs/xfs/Kconfig

View file

299

fs/xfs/linux-2.6/xfs_ioctl.c

View file

15

fs/xfs/linux-2.6/xfs_ioctl.h

View file

175

fs/xfs/linux-2.6/xfs_ioctl32.c

View file