drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths

Browse source

Currently we perform both short IRQ handling for DP, and connector
reprobing in the HPD IRQ handler. However since we need to grab
connection_mutex in order to reprobe a connector, in theory we could
accidentally block ourselves from handling any short IRQs until after a
modeset completes if a connector hotplug happens to occur in parallel
with a modeset.

I haven't seen this actually happen yet, but since we're cleaning up
nouveau's hotplug handling code anyway and we already have a hpd worker,
we can simply fix this by only relying on the HPD worker to actually
reprobe connectors when we receive a HPD IRQ. We also add a mask to
nouveau_drm to keep track of which connectors are waiting to be reprobed
in response to an HPD IRQ.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200826182456.322681-13-lyude@redhat.com

...

This commit is contained in:

Lyude Paul 2020-08-26 14:24:48 -04:00

parent 02bb7fe2d3

commit d297ce4b5d

7 changed files with 86 additions and 36 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

42

drivers/gpu/drm/nouveau/nouveau_connector.c

View file

1

drivers/gpu/drm/nouveau/nouveau_connector.h

View file

70

drivers/gpu/drm/nouveau/nouveau_display.c

View file

1

drivers/gpu/drm/nouveau/nouveau_display.h

View file

2

drivers/gpu/drm/nouveau/nouveau_dp.c

View file

4

drivers/gpu/drm/nouveau/nouveau_drm.c

View file

2

drivers/gpu/drm/nouveau/nouveau_drv.h

View file