nfsd4: clean up open owners on OPEN failure

Browse source

If process_open1() creates a new open owner, but the open later fails,
the current code will leave the open owner around.  It won't be on the
close_lru list, and the client isn't expected to send a CLOSE, so it
will hang around as long as the client does.

Similarly, if process_open1() removes an existing open owner from the
close lru, anticipating that an open owner that previously had no
associated stateid's now will, but the open subsequently fails, then
we'll again be left with the same leak.

Fix both problems.

Reported-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

J. Bruce Fields 2011-10-13 15:12:59 -04:00

parent bcf130f9df

commit d29b20cd58

4 changed files with 21 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

fs/nfsd/nfs4proc.c

View file

20

fs/nfsd/nfs4state.c

View file

1

fs/nfsd/state.h

View file

1

fs/nfsd/xdr4.h

View file