From d38be9217277ecbfb1bedb28132887229a45c376 Mon Sep 17 00:00:00 2001 From: Kuniyuki Iwashima Date: Mon, 18 May 2026 05:07:11 +0000 Subject: [PATCH] bareudp: Remove synchronize_net() in bareudp_sock_release(). synchronize_net() in bareudp_sock_release() has existed since day 1, commit 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc."). It was most likely copied from a similar tunneling device like vxlan or geneve. bareudp_sock_release() is called from dev->netdev_ops->ndo_stop(), and synchronize_net() in unregister_netdevice_many_notify() ensures that inflight bareudp fast paths finish before bareudp_dev is freed. Let's remove the redundant synchronize_net() in bareudp_sock_release(). Signed-off-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260518050726.318824-5-kuniyu@google.com Signed-off-by: Jakub Kicinski --- drivers/net/bareudp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 890a0650d9cf..bfcecdcffe67 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareudp.c @@ -287,7 +287,6 @@ static void bareudp_sock_release(struct bareudp_dev *bareudp) sk = bareudp->sk; rcu_assign_pointer(bareudp->sk, NULL); - synchronize_net(); udp_tunnel_sock_release(sk); }