staging: r8188eu: Remove _enter/_exit_critical_mutex()

Browse source

Remove _enter_critical_mutex() and _exit_critical_mutex(). They are
unnecessary wrappers, respectively to mutex_lock_interruptible() and
to mutex_unlock(). They also have an odd interface that takes an unused
argument named pirqL of type unsigned long.
The original code enters the critical section if the mutex API is
interrupted while waiting to acquire the lock; therefore it could lead
to a race condition. Use mutex_lock() because it is uninterruptible and
so avoid that above-mentioned potential race condition.

Tested-by: Pavel Skripkin <paskripkin@gmail.com>
Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210828113656.6963-1-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Fabio M. De Francesco 2021-08-28 13:36:56 +02:00 • committed by Greg Kroah-Hartman

parent f75a4eec49

commit d3ede18eeb

4 changed files with 6 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/staging/r8188eu/core/rtw_mlme_ext.c

View file

4

drivers/staging/r8188eu/hal/usb_ops_linux.c

View file

13

drivers/staging/r8188eu/include/osdep_service.h

View file

4

drivers/staging/r8188eu/os_dep/os_intfs.c

View file