bpf: Unify resource leak checks

Browse source

There are similar checks for covering locks, references, RCU read
sections and preempt_disable sections in 3 places in the verifer, i.e.
for tail calls, bpf_ld_[abs, ind], and exit path (for BPF_EXIT and
bpf_throw). Unify all of these into a common check_resource_leak
function to avoid code duplication.

Also update the error strings in selftests to the new ones in the same
change to ensure clean bisection.

Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20241103225940.1408302-3-memxor@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

...

This commit is contained in:

Kumar Kartikeya Dwivedi 2024-11-03 14:59:39 -08:00 • committed by Alexei Starovoitov

parent 46f7ed32f7

commit d402755ced

5 changed files with 46 additions and 68 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

90

kernel/bpf/verifier.c

View file

4

tools/testing/selftests/bpf/progs/exceptions_fail.c

View file

14

tools/testing/selftests/bpf/progs/preempt_lock.c

View file

4

tools/testing/selftests/bpf/progs/verifier_ref_tracking.c

View file

2

tools/testing/selftests/bpf/progs/verifier_spin_lock.c

View file