nfsd: Remove assignments inside conditions

Browse source

Assignments should not happen inside an if conditional, but in the line
before. This issue was reported by checkpatch.

The semantic patch that makes this change is as follows
(http://coccinelle.lip6.fr/):

// <smpl>

@@
identifier i1;
expression e1;
statement S;
@@
-if(!(i1 = e1)) S
+i1 = e1;
+if(!i1)
+S

// </smpl>

It has been tested by compilation.

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

Benoit Taine 2014-05-22 16:32:30 +02:00 • committed by J. Bruce Fields

parent f35ea0d4b6

commit d40aa3372f

4 changed files with 40 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

12

fs/nfsd/nfs2acl.c

View file

6

fs/nfsd/nfs3acl.c

View file

27

fs/nfsd/nfs3xdr.c

View file

15

fs/nfsd/nfsxdr.c

View file