bcachefs: Fix race between journal_seq_copy() and journal_seq_drop()

Browse source

In bch2_btree_interior_update_will_free_node, we copy the journal pins
from outstanding writes on the btree node we're about to free. But, this
can race with the writes completing, and dropping their journal pins.

To guard against this, just use READ_ONCE() in bch2_journal_pin_copy().

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2020-12-16 15:41:29 -05:00 • committed by Kent Overstreet

parent f30dd86012

commit d483dd17e2

2 changed files with 17 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

fs/bcachefs/journal_reclaim.c

View file

7

fs/bcachefs/journal_reclaim.h

View file