mtd: spi-nor: rename method for enabling or disabling octal DTR

Browse source

Having an *_enable(..., bool enable) definition was misleading
as the method is used both to enable and to disable the octal DTR
mode. Splitting the method in the core in two, one to enable and
another to disable the octal DTR mode does not make sense as the
method is straight forward and we'd introduce code duplication.

Update the core to use:
int (*set_octal_dtr)(struct spi_nor *nor, bool enable);

Manufacturer drivers use different sequences of commands to enable
and disable the octal DTR mode, thus for clarity they shall
implement it as:
static int manufacturer_snor_set_octal_dtr(struct spi_nor *nor, bool enable)
{
	return enable ? manufacturer_snor_octal_dtr_enable() :
			manufacturer_snor_octal_dtr_disable();
}

Reviewed-by: Michael Walle <mwalle@kernel.org>
Link: https://lore.kernel.org/r/20230714150757.15372-1-tudor.ambarus@linaro.org
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>

...

This commit is contained in:

Tudor Ambarus 2023-07-14 18:07:57 +03:00

parent 83e824a4a5

commit d4996700ab

No known key found for this signature in database

GPG key ID: 4B554F47A58D14E9

4 changed files with 13 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

12

drivers/mtd/spi-nor/core.c

View file

4

drivers/mtd/spi-nor/core.h

View file

4

drivers/mtd/spi-nor/micron-st.c

View file

6

drivers/mtd/spi-nor/spansion.c

View file