drm/amdkfd: Ensure consistent barrier state saved in gfx12 trap handler

Browse source

It is possible for some waves in a workgroup to finish their save
sequence before the group leader has had time to capture the workgroup
barrier state.  When this happens, having those waves exit do impact the
barrier state.  As a consequence, the state captured by the group leader
is invalid, and is eventually incorrectly restored.

This patch proposes to have all waves in a workgroup wait for each other
at the end of their save sequence (just before calling s_endpgm_saved).

Signed-off-by: Lancelot SIX <lancelot.six@amd.com>
Reviewed-by: Jay Cornwall <jay.cornwall@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org # 6.12.x

...

This commit is contained in:

Lancelot SIX 2025-01-28 19:16:49 +00:00 • committed by Alex Deucher

parent a0a455b4bc

commit d584198a6f

2 changed files with 6 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/amd/amdkfd/cwsr_trap_handler.h

View file

4

drivers/gpu/drm/amd/amdkfd/cwsr_trap_handler_gfx12.asm

View file