nfp: forbid disabling hw-tc-offload on representors while offload active

Browse source

All netdevs which can accept TC offloads must implement
.ndo_set_features().  nfp_reprs currently do not do that, which
means hw-tc-offload can be turned on and off even when offloads
are active.

Whether the offloads are active is really a question to nfp_ports,
so remove the per-app tc_busy callback indirection thing, and
simply count the number of offloaded items in nfp_port structure.

Fixes: 8a2768732a ("nfp: provide infrastructure for offloading flower based TC filters")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Tested-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Jakub Kicinski 2018-02-07 20:55:24 -08:00 • committed by David S. Miller

parent 0b9de4ca85

commit d692403e5c

7 changed files with 33 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/net/ethernet/netronome/nfp/bpf/main.c

View file

4

drivers/net/ethernet/netronome/nfp/flower/offload.c

View file

9

drivers/net/ethernet/netronome/nfp/nfp_app.h

View file

7

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

View file

1

drivers/net/ethernet/netronome/nfp/nfp_net_repr.c

View file

18

drivers/net/ethernet/netronome/nfp/nfp_port.c

View file

6

drivers/net/ethernet/netronome/nfp/nfp_port.h

View file