HID: wiimote: wake up if output queue failed

Browse source

Our output queue is asynchronous but synchronous reports may wait for a
response to their request. Therefore, wake them up unconditionally if an
output report couldn't be sent. But keep the report ID intact so we don't
incorrectly assume our request succeeded.

Note that the underlying connection is required to be reliable and does
retransmission itself. So it is safe to assume that if the transmission
fails, the device is in inconsistent state. Hence, we abort every request
if any output report fails. No need to verify which report failed.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

...

This commit is contained in:

David Herrmann 2013-05-05 23:12:50 +02:00 • committed by Jiri Kosina

parent 6b80bb94dc

commit d758b1f0c5

2 changed files with 38 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

24

drivers/hid/hid-wiimote-core.c

View file

19

drivers/hid/hid-wiimote.h

View file