V4L/DVB (13831): uvcvideo: Fix oops caused by a race condition in buffer dequeuing

Browse source

Buffers were marked as done before being removed from the IRQ queue. If
a userspace application dequeued and requeued the buffer fast enough
during that time window, the buffer could end up being deleted twice,
generating an oops in interrupt context.

Add a new state, UVC_BUF_STATE_READY, to mark buffers as ready for reuse
but not yet removed from the queue, and transition to UVC_BUF_STATE_DONE
only when the buffer is removed from the queue.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

...

This commit is contained in:

Laurent Pinchart 2009-12-16 21:20:45 -03:00 • committed by Mauro Carvalho Chehab

parent 2c4d9de8ab

commit d7c0d43997

3 changed files with 18 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

13

drivers/media/video/uvc/uvc_queue.c

View file

14

drivers/media/video/uvc/uvc_video.c

View file

5

drivers/media/video/uvc/uvcvideo.h

View file