media: allegro: drop length field from message header

Browse source

The length of the message will be determined when the message is
encoded.  Writing the size of the struct into the message in the driver
won't be the actual length of the message that is send to the firmware.
Therefore, drop the length field from the message.

Since the header is the same for all response messages, it does not make
sense to read the header in each decoding function, but we can simply
decode it once before dispatching to the respective functions.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

...

This commit is contained in:

Michael Tretter 2020-07-13 16:42:27 +02:00 • committed by Mauro Carvalho Chehab

parent c7ce107f9d

commit d8fefda89e

3 changed files with 5 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/staging/media/allegro-dvt/allegro-core.c

View file

13

drivers/staging/media/allegro-dvt/allegro-mail.c

View file

3

drivers/staging/media/allegro-dvt/allegro-mail.h

View file