usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command

Browse source

According the programming guide (for all DWC3 IPs), when the driver
handles ClearFeature(halt) request, it should issue CLEAR_STALL command
_after_ the END_TRANSFER command completes. The END_TRANSFER command may
take some time to complete. So, delay the ClearFeature(halt) request
control status stage and wait for END_TRANSFER command completion
interrupt. Only after END_TRANSFER command completes that the driver
may issue CLEAR_STALL command.

Cc: stable@vger.kernel.org
Fixes: cb11ea56f3 ("usb: dwc3: gadget: Properly handle ClearFeature(halt)")
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

...

This commit is contained in:

Thinh Nguyen 2020-09-02 18:43:04 -07:00 • committed by Felipe Balbi

parent c503672abe

commit d97c78a190

4 changed files with 50 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/usb/dwc3/core.h

View file

16

drivers/usb/dwc3/ep0.c

View file

40

drivers/usb/dwc3/gadget.c

View file

1

drivers/usb/dwc3/gadget.h

View file