drm/amd/display: Fix IPS handshake for idle optimizations

Browse source

[Why]
Intermittent reboot hangs are observed introduced by
"Improve x86 and dmub ips handshake".

[How]
Bring back the commit but fix the polling.

Avoid hanging in place forever by bounding the delay and ensure that
we still message DMCUB on IPS2 exit to notify driver idle has been
cleared.

Reviewed-by: Duncan Ma <duncan.ma@amd.com>
Reviewed-by: Jun Lei <jun.lei@amd.com>
Acked-by: Roman Li <roman.li@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Nicholas Kazlauskas 2023-10-05 11:48:44 -04:00 • committed by Alex Deucher

parent 488bb99d42

commit da2d16fcdd

10 changed files with 141 additions and 27 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

37

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c

View file

14

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_smu.c

View file

4

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_smu.h

View file

2

drivers/gpu/drm/amd/display/dc/dc.h

View file

73

drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c

View file

2

drivers/gpu/drm/amd/display/dc/dcn35/dcn35_init.c

View file

2

drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c

View file

30

drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c

View file

3

drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.h

View file

1

drivers/gpu/drm/amd/display/dc/hwss/hw_sequencer.h

View file