drm/msm/hdmi: remove ->reset() from HDMI PHY

Browse source

->reset() currently only accesses HDMI core registers, and yet it
is located in hdmi_phy*. Since no PHY registers are being
accessed during ->reset(), it would be better to bring that
function in hdmi core module where HDMI core registers are
usually being accessed.

This will also help for msm8x94 for which no PHY registers
accesses are done (->phy_init == NULL) but the HDMI PHY reset
from HDMI core still needs to be done.

Note:
SW_RESET_PLL bit is not written in hdmi_phy_8x60_reset(); this
write should not affect anything if the corresponding field is
not writable.

Signed-off-by: Stephane Viau <sviau@codeaurora.org>
[fixed warning about unused 'phy' in hpd_enable() while merging]
Signed-off-by: Rob Clark <robdclark@gmail.com>

...

This commit is contained in:

Stephane Viau 2015-06-19 16:04:46 -04:00 • committed by Rob Clark

parent dcefc117cc

commit da32855219

5 changed files with 50 additions and 144 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/gpu/drm/msm/hdmi/hdmi.h

View file

52

drivers/gpu/drm/msm/hdmi/hdmi_connector.c

View file

52

drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c

View file

32

drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c

View file

57

drivers/gpu/drm/msm/hdmi/hdmi_phy_8x74.c

View file