agp: two-stage page destruction issue

Browse source

besides it apparently being useful only in 2.6.24 (the changes in 2.6.25
really mean that it could be converted back to a single-stage mechanism),
I'm seeing an issue in Xen Dom0 kernels, which is caused by the calling
of gart_to_virt() in the second stage invocations of the destroy function.
I think that besides this being a real issue with Xen (where
unmap_page_from_agp() is not just a page table attribute change), this
also is invalid from a theoretical perspective: One should not assume that
gart_to_virt() is still valid after unmapping a page. So minimally (keeping
the 2-stage mechanism) a patch like the one below would be needed.

Jan

Signed-off-by: Dave Airlie <airlied@redhat.com>

...

This commit is contained in:

Jan Beulich 2008-06-18 09:28:00 +01:00 • committed by Dave Airlie

parent dcd981a77b

commit da503fa60b

3 changed files with 17 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

drivers/char/agp/backend.c

View file

7

drivers/char/agp/generic.c

View file

6

drivers/char/agp/intel-agp.c

View file