net/tcp: Consistently align TCP-AO option in the header

Browse source

Currently functions that pre-calculate TCP header options length use
unaligned TCP-AO header + MAC-length for skb reservation.
And the functions that actually write TCP-AO options into skb do align
the header. Nothing good can come out of this for ((maclen % 4) != 0).

Provide tcp_ao_len_aligned() helper and use it everywhere for TCP
header options space calculations.

Fixes: 1e03d32bea ("net/tcp: Add TCP-AO sign to outgoing packets")
Signed-off-by: Dmitry Safonov <dima@arista.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

...

This commit is contained in:

Dmitry Safonov 2023-12-04 19:00:41 +00:00 • committed by Paolo Abeni

parent 714589c274

commit da7dfaa6d6

6 changed files with 15 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

include/net/tcp_ao.h

View file

4

net/ipv4/tcp_ao.c

View file

4

net/ipv4/tcp_ipv4.c

View file

2

net/ipv4/tcp_minisocks.c

View file

6

net/ipv4/tcp_output.c

View file

2

net/ipv6/tcp_ipv6.c

View file