mac80211: split ieee80211_key_alloc/free

Browse source

In order to RCU-ify sta_info, we need to be able to allocate
a key without linking it to an sdata/sta structure (because
allocation cannot be done in an rcu critical section). This
patch splits up ieee80211_key_alloc() and updates all users
appropriately.

While at it, this patch fixes a number of race conditions
such as finally making key replacement atomic, unfortunately
at the expense of more complex code.

Note that this patch documents /existing/ bugs with sta info
and key interaction, there is currently a race condition
when a sta info is freed without holding the RTNL. This will
finally be fixed by a followup patch.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Johannes Berg 2008-02-25 16:27:45 +01:00 • committed by John W. Linville

parent 6f48422a29

commit db4d1169d0

5 changed files with 203 additions and 98 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

27

net/mac80211/cfg.c

View file

100

net/mac80211/ieee80211_ioctl.c

View file

26

net/mac80211/ieee80211_key.h

View file

158

net/mac80211/key.c

View file

2

net/mac80211/sta_info.c

View file