i40e/i40evf: always set the CLEARPBA flag when re-enabling interrupts

Browse source

In the past we changed driver behavior to not clear the PBA when
re-enabling interrupts. This change was motivated by the flawed belief
that clearing the PBA would cause a lost interrupt if a receive
interrupt occurred while interrupts were disabled.

According to empirical testing this isn't the case. Additionally, the
data sheet specifically says that we should set the CLEARPBA bit when
re-enabling interrupts in a polling setup.

This reverts commit 40d72a5098 ("i40e/i40evf: don't lose interrupts")

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

...

This commit is contained in:

Jacob Keller 2017-09-07 08:05:49 -04:00 • committed by Jeff Kirsher

parent 4270255929

commit dbadbbe235

5 changed files with 10 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/net/ethernet/intel/i40e/i40e.h

View file

11

drivers/net/ethernet/intel/i40e/i40e_main.c

View file

6

drivers/net/ethernet/intel/i40e/i40e_txrx.c

View file

2

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

View file

4

drivers/net/ethernet/intel/i40evf/i40e_txrx.c

View file