s390/dump: fix old lowcore virtual vs physical address confusion

Browse source

Virtual addresses of vmcore_info and os_info members are
wrongly passed to copy_oldmem_kernel(), while the function
expects physical address of the source. Instead, __pa()
macro should have been applied.

Yet, use of __pa() macro could be somehow confusing, since
copy_oldmem_kernel() may treat the source as an offset, not
as a direct physical address (that depens from the oldmem
availability and location).

Fix the virtual vs physical address confusion and make the
way the old lowcore is read consistent across all sources.

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

...

This commit is contained in:

Alexander Gordeev 2022-01-29 08:38:56 +01:00 • committed by Vasily Gorbik

parent ba2d394c60

commit dc306186a1

3 changed files with 5 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/s390/kernel/asm-offsets.c

View file

2

arch/s390/kernel/crash_dump.c

View file

3

arch/s390/kernel/os_info.c

View file