tpm: fix crash in tpm_tis deinitialization

Browse source

rmmod crashes the driver because tpm_chip_unregister() already sets ops
to NULL. This commit fixes the issue by moving tpm2_shutdown() to
tpm_chip_unregister(). This commit is also cleanup because it removes
duplicate code from tpm_crb and tpm_tis to the core.

Fixes: 4d3eac5e156a ("tpm: Provide strong locking for device removal")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

...

This commit is contained in:

Jarkko Sakkinen 2016-04-11 14:20:57 +03:00

parent d30b8e4f68

commit dcbeab1946

4 changed files with 1 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/char/tpm/tpm-chip.c

View file

1

drivers/char/tpm/tpm2-cmd.c

View file

3

drivers/char/tpm/tpm_crb.c

View file

3

drivers/char/tpm/tpm_tis.c

View file