p54usb: rewriting rx/tx routines to make use of usb_anchor's facilities

Browse source

Alan Stern found several flaws in p54usb's implementation and annotated:
"usb_kill_urb() and similar routines do not expect an URB's completion
routine to deallocate it.  This is almost obvious -- if the URB is deallocated
before the completion routine returns then there's no way for usb_kill_urb
to detect when the URB actually is complete."

This patch addresses all known limitations in the old implementation and fixes
khub's "use-after-freed" hang, when SLUB debug's poisoning option is enabled.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
Cc: stable@kernel.org
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Christian Lamparter 2008-12-09 15:14:37 +01:00 • committed by John W. Linville

parent a07d3619fa

commit dd397dc9dd

2 changed files with 102 additions and 50 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

151

drivers/net/wireless/p54/p54usb.c

View file

1

drivers/net/wireless/p54/p54usb.h

View file