nvmet: remove unnecessary ctrl parameter

Browse source

The function nvmet_ctrl_find_get() accepts out pointer to nvmet_ctrl
structure. This function returns the same error value from two places
that is :- NVME_SC_CONNECT_INVALID_PARAM | NVME_SC_DNR.

Move this to the caller so we can change the return type to nvmet_ctrl.

Now that we can changed the return type, instead of taking out pointer
to the nvmet_ctrl structure remove that function parameter and return
the valid nvmet_ctrl pointer on success and NULL on failure.

Also, add and rename the goto labels for more readability with comments.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Chaitanya Kulkarni 2021-03-09 17:16:32 -08:00 • committed by Christoph Hellwig

parent b53d47418d

commit de5878048e

3 changed files with 20 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

drivers/nvme/target/core.c

View file

11

drivers/nvme/target/fabrics-cmd.c

View file

5

drivers/nvme/target/nvmet.h

View file