drm/v3d: Fix a use-after-free race accessing the scheduler's fences.

Browse source

[ Upstream commit 34c2c4f632 ]

Once we push the job, the scheduler could run it and free it.  So, if
we want to reference their fences, we need to grab them before then.
I haven't seen this happen in many days of conformance test runtime,
but let's still close the race.

Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: 57692c94dc ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+")
Link: https://patchwork.freedesktop.org/patch/254119/
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Eric Anholt 2018-09-28 16:21:23 -07:00 • committed by Greg Kroah-Hartman

parent bf7ac708dd

commit de6a6f5151

2 changed files with 11 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/gpu/drm/v3d/v3d_drv.h

View file

8

drivers/gpu/drm/v3d/v3d_gem.c

View file