drm/i915/guc: Drop guc->interrupts.enabled

Browse source

Drop the variable guc->interrupts.enabled as this variable is just
leading to bugs creeping into the code.

e.g. A full GPU reset disables the GuC interrupts but forgot to clear
guc->interrupts.enabled, guc->interrupts.enabled being true suppresses
interrupts from getting re-enabled and now we are broken.

It is harmless to enable interrupt while already enabled so let's just
delete this variable to avoid bugs like this going forward.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210603051630.2635-7-matthew.brost@intel.com

...

This commit is contained in:

Matthew Brost 2021-06-02 22:16:16 -07:00 • committed by Daniel Vetter

parent 0a8e247dc1

commit ded32d381c

2 changed files with 9 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

27

drivers/gpu/drm/i915/gt/uc/intel_guc.c

View file

1

drivers/gpu/drm/i915/gt/uc/intel_guc.h

View file