bcachefs: Add an assertion in bch2_journal_pin_set()

Browse source

Previously, bch2_journal_pin_set() would silently ignore a request to
pin a journal sequence number that was no longer dirty, because it was
used internally by bch2_journal_pin_copy() which could race with the src
pin being flushed.

Split these apart so that we can properly assert that @seq is a
currently dirty journal sequence number - this is almost always a bug.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2023-11-07 12:32:50 -05:00

parent fa5df9e7d5

commit df8e13ccf3

2 changed files with 51 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

59

fs/bcachefs/journal_reclaim.c

View file

15

fs/bcachefs/journal_reclaim.h

View file