staging: rtl8723bs: remove unused network_type_in_use field

Browse source

The network_type_in_use member of struct wlan_bssid_ex is write-only:
nothing in the driver ever reads it. It is assigned in three places,
none of which feed anything:

  - collect_bss_info() hard-codes it to Ndis802_11OFDM24 for every
    parsed beacon/probe response, regardless of the network's actual
    band or rates (it is even wrong for 5 GHz APs, which the same
    function explicitly handles).
  - rtw_check_beacon_data() and rtw_update_registrypriv_dev_network()
    derive it from the wireless mode via a switch, but the result is
    likewise never consumed.

The live PHY classification the driver actually acts on is kept in
wlan_network.network_type (the WIRELESS_11x value), so this NDIS-era
field is redundant.

struct wlan_bssid_ex is an internal structure passed by pointer through
the driver command queue; it is never serialized to firmware or onto
the air (the wire data lives in ies[]), so dropping a member is
layout-safe as long as the module is rebuilt as a whole.

enum ndis_802_11_network_type existed only to type this field, so
remove it as well. No functional change.

Signed-off-by: Cong Nguyen <congnt264@gmail.com>
Link: https://patch.msgid.link/20260603122806.1330145-1-congnt264@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Cong Nguyen 2026-06-03 19:28:06 +07:00 • committed by Greg Kroah-Hartman

parent deec171bb5

commit df8ec79e1e

4 changed files with 1 additions and 43 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

15

drivers/staging/rtl8723bs/core/rtw_ap.c

View file

16

drivers/staging/rtl8723bs/core/rtw_mlme.c

View file

2

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

View file

11

drivers/staging/rtl8723bs/include/wlan_bssdef.h

View file