mtd: nand: denali: clean up macros with <linux/bitfield.h>

Browse source

All the register offsets and bitfield masks are defined in denali.h,
but the driver code ended up with additional crappy macros such as
MAKE_ECC_CORRECTION(), ECC_SECTOR(), etc.

The reason is apparent - accessing a register field requires mask and
shift pair.  The denali.h only provides mask.  However, defining both
is tedious.

<linux/bitfield.h> provides a convenient way to get register fields
only with a single shifted mask.  Now use it.

While I am here, I shortened some macros.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

...

This commit is contained in:

Masahiro Yamada 2017-09-22 12:46:43 +09:00 • committed by Boris Brezillon

parent fdd4d0836b

commit e0d53b3f8e

2 changed files with 16 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

drivers/mtd/nand/denali.c

View file

13

drivers/mtd/nand/denali.h

View file