drm/i915: Clean up PCI config register handling

Browse source

Do not use magic numbers, do not prefix stuff with "PCI_", do not
declare registers in implementation files. Also move the PCI
registers under correct comment in i915_reg.h.

v2:
- Consistently use BSM (not BDSM or other variants from PRM) (Chris)
- Also include register address to help identify the register (Chris)
v3:
- Refer to register value as *_val instead of *_reg (Chris)
v4:
- Make style checker happy

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

...

This commit is contained in:

Joonas Lahtinen 2016-04-15 12:03:39 +03:00

parent 44a7102484

commit e10fa551ae

5 changed files with 63 additions and 49 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

32

drivers/gpu/drm/i915/i915_dma.c

View file

14

drivers/gpu/drm/i915/i915_gem_stolen.c

View file

38

drivers/gpu/drm/i915/i915_reg.h

View file

24

drivers/gpu/drm/i915/intel_opregion.c

View file

4

drivers/gpu/drm/i915/intel_panel.c

View file