s390/qeth: sanitize strings in debug messages

Browse source

As Documentation/s390/s390dbf.txt states quite clearly, using any
pointer in sprinf-formatted s390dbf debug entries is dangerous.
The pointers are dereferenced whenever the trace file is read from.
So if the referenced data has a shorter life-time than the trace file,
any read operation can result in a use-after-free.

So rip out all hazardous use of indirect data, and replace any usage of
dev_name() and such by the Bus ID number.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Julian Wiedmann 2018-11-02 19:04:08 +01:00 • committed by David S. Miller

parent 265ad0632f

commit e19e5be8b4

4 changed files with 119 additions and 151 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

15

drivers/s390/net/qeth_core.h

View file

127

drivers/s390/net/qeth_core_main.c

View file

24

drivers/s390/net/qeth_l2_main.c

View file

104

drivers/s390/net/qeth_l3_main.c

View file