From e1afb47e4f3911047abcaa8fb8f5ab285d3e51ff Mon Sep 17 00:00:00 2001 From: Hungyu Lin Date: Thu, 21 May 2026 10:43:15 +0000 Subject: [PATCH] staging: rtl8723bs: simplify LPS_RF_ON_check control flow Replace err + break pattern with direct returns to simplify the control flow and improve readability. No functional change intended. Signed-off-by: Hungyu Lin Link: https://patch.msgid.link/20260521104316.27739-2-dennylin0707@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index b9f8cf1014ed..9d1a81902643 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -397,27 +397,21 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) { unsigned long start_time; u8 bAwake = false; - s32 err = 0; start_time = jiffies; while (1) { rtw_hal_get_hwreg(padapter, HW_VAR_FWLPS_RF_ON, &bAwake); if (bAwake) - break; + return 0; - if (padapter->bSurpriseRemoved) { - err = -2; - break; - } + if (padapter->bSurpriseRemoved) + return -2; + + if (jiffies_to_msecs(jiffies - start_time) > delay_ms) + return -1; - if (jiffies_to_msecs(jiffies - start_time) > delay_ms) { - err = -1; - break; - } msleep(1); } - - return err; } /* Description: Enter the leisure power save mode. */