bcachefs: More improvements for alloc info checks

Browse source

- Move checks for whether the device & bucket are valid from the
   .key_invalid method to bch2_check_alloc_key(). This is because
   .key_invalid() is called on keys that may no longer exist (post
   journal replay), which is a problem when removing/resizing devices.

 - We weren't checking the need_discard btree to ensure that every set
   bucket has a corresponding alloc key. This refactors the code for
   checking the freespace btree, so that it now checks both.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>

...

This commit is contained in:

Kent Overstreet 2022-04-05 13:44:18 -04:00 • committed by Kent Overstreet

parent afb6f7f61b

commit e1effd42a1

5 changed files with 81 additions and 99 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

144

fs/bcachefs/alloc_background.c

View file

14

fs/bcachefs/alloc_background.h

View file

13

fs/bcachefs/buckets.c

View file

2

fs/bcachefs/recovery.c

View file

9

fs/bcachefs/super.c

View file