drm/i915: tame the chattermouth (v2)

Browse source

Many distro's have mechanism in place to collect and automatically file
bugs for failed WARN()s.  And since i915 has a lot of hw state sanity
checks which result in WARN(), it generates quite a lot of noise which
is somewhat disconcerting to the end user.

Separate out the internal hw-is-in-the-state-I-expected checks into
I915_STATE_WARN()s and allow configuration via i915.verbose_checks module
param about whether this will generate a full blown stacktrace or just
DRM_ERROR().  The new moduleparam defaults to true, so by default there
is no change in behavior.  And even when disabled, you will still get
an error message logged.

v2: paint the macro names blue, clarify that the default behavior
    remains the same as before

Signed-off-by: Rob Clark <robdclark@gmail.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

...

This commit is contained in:

Rob Clark 2014-12-15 13:56:32 -05:00 • committed by Daniel Vetter

parent e6c1abb739

commit e2c719b75c

5 changed files with 105 additions and 70 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

30

drivers/gpu/drm/i915/i915_drv.h

View file

5

drivers/gpu/drm/i915/i915_params.c

View file

134

drivers/gpu/drm/i915/intel_display.c

View file

4

drivers/gpu/drm/i915/intel_dp.c

View file

2

drivers/gpu/drm/i915/intel_runtime_pm.c

View file