misc: ad525x_dpot: use driver core groups for sysfs files

Browse source

ad_dpot_probe() creates per-RDAC sysfs files manually and then
optionally creates the command sysfs group. This leaves probe responsible
for rolling back partial sysfs state and makes remove responsible for
matching every file that probe created.

Move the device attributes into driver core dev_groups for the I2C and
SPI drivers and use an is_visible() callback to expose only the
attributes supported by the probed device. With this shape, the driver
core creates the sysfs files only after probe succeeds and removes them
before the remove callback frees the driver data.

Fixes: 4eb174bee6 ("ad525x_dpot: new driver for AD525x digital potentiometers")
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Link: https://patch.msgid.link/20260623015643.36508-1-pengpeng@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Pengpeng Hou 2026-06-23 09:56:43 +08:00 • committed by Greg Kroah-Hartman

parent 0764fd1040

commit e3a8557e88

4 changed files with 112 additions and 70 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/misc/ad525x_dpot-i2c.c

View file

1

drivers/misc/ad525x_dpot-spi.c

View file

177

drivers/misc/ad525x_dpot.c

View file

3

drivers/misc/ad525x_dpot.h

View file